Fix unnecessary caret movement when switching tabs #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexPl292
reviewed
May 13, 2021
| @@ -79,7 +79,7 @@ class RegisterActionsTest : VimTestCase() { | |||
| val after = "I f${c}ound it in a legendary land" | |||
| var motionRightAction: ActionBeanClass? = null | |||
| doTest(keys, before, after, CommandState.Mode.COMMAND, CommandState.SubMode.NONE) { | |||
| motionRightAction = VIM_ACTIONS_EP.extensions().findAny().get() | |||
| motionRightAction = VIM_ACTIONS_EP.extensions().filter { it.actionId == "VimPreviousTabAction" }.findFirst().get() | |||
There was a problem hiding this comment.
The PR is good, but what is this change about?
There was a problem hiding this comment.
It makes the action we're using explicit, rather than relying on the order of the actions in VimActions.xml. The findAny function is documented as returning "any" item from the collection, but in practice it was returning the first item, which just happened to be the "previous tab action". I moved that action from the motion.tabs package to windows.tab, and moved the registration in VimActions.xml to match, and that broke the assumption on the order of the actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
gtandgTactions fromMotionActionHandlertoVimActionHandler, as they're not motions. This was causing a problem because IdeaVim would switch tabs then try to move the caret to the current offset, which we don't optimise away because it might result in a different visual position thanks to inlays. Because the editor was no longer visible, the visible area is effectively zero, and repositioning the caret to fit in this area would move it to the top left of the editor. Fixes VIM-2308