Refactor SearchGroup #260
Merged
Refactor SearchGroup #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No code changes, just moved everything
|
So many comments. Awesome, thank you! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the groundwork for VIM-2173 that began in #257, this PR refactors
SearchGroup. There are no code changes, only moving methods around. This is a separate PR to make the next PR easier to review - it will be making code changes without moving things around 😄SearchHelper. The methods inSearchGroupare now the "high level" APIs to implement Vim's search and replace functionality. They maintain state, parse commands and call intoSearchHelperto do the actual searching.SearchGroupto better understand what the methods are doing (there are quite a few overloads simply calledsearchthat do different things with state and carets, etc.)Direction.UNSETintroduced in Extract SearchHighlightsHelper from SearchGroup #257