VIM-2114 Do not override registers when deleting empty range

JetBrains · Nov 13, 2020 · 75a1bb7 · 75a1bb7
1 parent 7d6a643
commit 75a1bb7
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/com/maddyhome/idea/vim/group/RegisterGroup.java b/src/com/maddyhome/idea/vim/group/RegisterGroup.java
@@ -179,6 +179,11 @@ public boolean storeTextInternal(@NotNull Editor editor, @NotNull TextRange rang
 
     int start = range.getStartOffset();
     int end = range.getEndOffset();
+
+    if (isDelete && start == end) {
+      return true;
+    }
+
     // Normalize the start and end
     if (start > end) {
       int t = start;

diff --git a/test/org/jetbrains/plugins/ideavim/action/CopyActionTest.java b/test/org/jetbrains/plugins/ideavim/action/CopyActionTest.java
@@ -218,4 +218,16 @@ public void testPutInEmptyFile() {
     typeTextInFile(parseKeys("\"ap"), "");
     myFixture.checkResult("test");
   }
+
+  public void testOverridingRegisterWithEmptyTag() {
+    configureByText("<root>\n" +
+                    "<a><caret>value</a>\n" +
+                    "<b></b>\n" +
+                    "</root>\n");
+    typeText(parseKeys("dit", "j", "cit", "<C-R>\""));
+    myFixture.checkResult("<root>\n" +
+                          "<a></a>\n" +
+                          "<b>value</b>\n" +
+                          "</root>\n");
+  }
 }