Fix Removed child count (0) was not what we expected (1) #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msand
added a commit
to software-mansion/react-native-svg
that referenced
this pull request
Feb 9, 2019
Attempt to fix issues with removeChildren and manageChildren bugs, causing exceptions from RCTUIManager Related to #258 and #848 facebook/react-native#23350 https://github.com/FormidableLabs/victory-native/issues/432 indiespirit/react-native-chart-kit#62 JesperLekland/react-native-svg-charts#280 JesperLekland/react-native-svg-charts#244
msand
added a commit
to software-mansion/react-native-svg
that referenced
this pull request
Feb 9, 2019
Fixed issues with removeChildren and manageChildren bugs, causing exceptions from RCTUIManager Related to #258 and #848 facebook/react-native#23350 https://github.com/FormidableLabs/victory-native/issues/432 indiespirit/react-native-chart-kit#62 JesperLekland/react-native-svg-charts#280 JesperLekland/react-native-svg-charts#244
|
The root cause for this has been fixed in react-native-svg v9.2.4, and the most efficient workaround for backwards compatibility is to wrap any Defs elements in a G element, rather than the dynamic content. |
JesperLekland
requested changes
Jul 6, 2019
There was a problem hiding this comment.
First and foremost thank you for your PR.
Secondly I'm super sorry for the late reply, I simply haven't had time to maintain this library.
If this is to be fixed it should be fixed in all relevant charts. However I'm not sure a "workaround" should be merged into the library it self. The user could simply wrap their children in a <G> and all should be fine and dandy. Don't you agree?
JackWillie
added a commit
to JackWillie/react-native-svg
that referenced
this pull request
Nov 27, 2022
Attempt to fix issues with removeChildren and manageChildren bugs, causing exceptions from RCTUIManager Related to #258 and #848 facebook/react-native#23350 https://github.com/FormidableLabs/victory-native/issues/432 indiespirit/react-native-chart-kit#62 JesperLekland/react-native-svg-charts#280 JesperLekland/react-native-svg-charts#244
JackWillie
added a commit
to JackWillie/react-native-svg
that referenced
this pull request
Nov 27, 2022
Fixed issues with removeChildren and manageChildren bugs, causing exceptions from RCTUIManager Related to #258 and #848 facebook/react-native#23350 https://github.com/FormidableLabs/victory-native/issues/432 indiespirit/react-native-chart-kit#62 JesperLekland/react-native-svg-charts#280 JesperLekland/react-native-svg-charts#244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
software-mansion/react-native-svg#848 (comment)