Implement display-bound attribute for derive-Display macro (#93) #97
Conversation
340e37a to
c124e84
Compare
Done. |
src/display.rs
Outdated
| }, | ||
| nested: inner_meta, | ||
| .. | ||
| }) => { |
There was a problem hiding this comment.
I guess this nested beast could be rewritten as we've discussed.
src/display.rs
Outdated
| TraitBoundModifier, | ||
| Type, | ||
| TypeParamBound, | ||
| TypePath, |
There was a problem hiding this comment.
Why import all this? Is using syn::Type or syn::TypeParamBound is too bad and requires syn:: part to be removed?
This has sense if there is a really long paths, to shorten it for better readability. The punctuated::Punctuated is a good example. However, in much cases syn::Something is quite good enough.
There was a problem hiding this comment.
Just followed existing style here. I'm for explicitly prefixing syn:: personally.
There was a problem hiding this comment.
@JelteF wouldn't you mind on some cosmetic refactoring for src/display.rs file?
There was a problem hiding this comment.
Sounds good for the changes made here, but if it touches code in another part of the file let's do that in another PR.
| @@ -99,6 +114,50 @@ pub fn expand(input: &DeriveInput, trait_name: &str) -> Result<TokenStream> { | |||
| }) | |||
| } | |||
|
|
|||
| fn trait_name_to_attribute_name(trait_name: &str) -> &'static str { | |||
There was a problem hiding this comment.
Consider to use smart well-known abbreviations, like attr instead attribute.
|
That's what you get when you use nightly by default. Should be fixed now. |
|
I think it's good now. It's still a draft PR. Is that on purpose? If no, I will merge this PR. |
Undrafted. (: |
Second half of #93. This PR is based on top of #95.
Implemented
[display(bound = "...")]attribute forDisplaymacro as proposed by @tyranron in #93.