Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some improvements regarding type checking. The main things include:
assert
because mypy does not yet support analysing assertIsNotNone and similar functions (see assertIsNotNone(foo) in tests is not treated the same asassert foo is not None
python/mypy#5088 and the linked issue Narrow types using overload information python/mypy#4063)py.typed
marker to denote that this library has type hints (see PEP 561)If you're not interested in some parts of this PR I can create a new one with only the parts you're interested in.