Update cicd #20
Merged
Update cicd #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump action versions. Use `pip install -e .` instead of `python setup.py develop` as the latter is now deprecated. Trying to fix issue with jinja2 being deprecated.
The following error arises while `Test package` executes in the workflow. The following suggestion was followed: d2l-ai/d2l-book#46 (comment)
Recursively checkout submodules
Add libraries for notebooks
JelleAalbers
reviewed
Aug 9, 2024
There was a problem hiding this comment.
Thanks Lorenzo! Do we need to require seaborn to run the notebook tests? I don't see it used currently.
Other than that this is fine to merge.
(We don't use submodules either currently, but I see you're experimenting with this in your other PRs, so this is fine.)
|
Hi Jelle, This PR (#17) introduces both submodules and seaborn in the If you prefer, I can move those specific changes in the other PR. Otherwise, I'll proceed with the merge. |
JelleAalbers
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I have updated the CI workflow so that it tests from python3.9 to 3.12 and uses the latest GitHub actions.
The workflow does not invoke setup.py directly anymore as it is now deprecated behaviour.
Also I fixed a bug with nbconvert that requires an older version of the jinja package.