Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): mitigate GitHub API rate limit #276

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Sep 8, 2024

macOS ROOT build job is unable to get the source code URL, since we seemed to have exceeded the GitHub API rate limit. I may be able to use a PAT to drastically increase our limits, but for now let's go with the simpler solution:

  • assume the source code URL
  • add a max ROOT version to minimum-version.sh (regression, since before this PR, getting the latest tag was automatic thanks to the GitHub API)

@c-dilks c-dilks marked this pull request as ready for review September 9, 2024 00:04
@c-dilks c-dilks changed the title fix(CI): ROOT build on macOS fix(CI): mitigate GitHub API rate limit Sep 9, 2024
@c-dilks c-dilks merged commit dfcdf24 into main Sep 9, 2024
45 checks passed
@c-dilks c-dilks deleted the fix-macos-root-download branch September 9, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
1 participant