Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(chameleon): decrease minimum ruby version and test it #257

Merged
merged 18 commits into from
Aug 5, 2024

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Jul 24, 2024

Stability of chameleon is rather critical, since it generates bindings (and eventually tests). Since users may have older versions of Ruby, we should be sure it works the same for those.

Unfortunately, installing an older version of Ruby is not so straightforward in the Arch container; we can't simply use a workflow action or the Arch Linux Archive. Instead, we use rbenv and cache the resulting build (analogous to a Python virtual environment).

@c-dilks c-dilks requested a review from rtysonCLAS12 as a code owner August 4, 2024 15:39
@c-dilks c-dilks deleted the branch main August 4, 2024 15:41
@c-dilks c-dilks closed this Aug 4, 2024
@c-dilks c-dilks reopened this Aug 4, 2024
@c-dilks c-dilks changed the base branch from BASE-rcdb to main August 4, 2024 15:44
@c-dilks c-dilks marked this pull request as draft August 4, 2024 15:44
@c-dilks
Copy link
Member Author

c-dilks commented Aug 4, 2024

@c-dilks deleted the branch main 4 minutes ago

I certainly did not! I think this is because I rebased onto main, then deleted the original base branch BASE-rcdb before trying to change it to main. This was a mistake, and seems to have confused GitHub.

@c-dilks c-dilks marked this pull request as ready for review August 4, 2024 23:51
@c-dilks c-dilks merged commit 9dbab20 into main Aug 5, 2024
45 checks passed
@c-dilks c-dilks deleted the ruby-minver branch August 5, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant