Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add FD cut for pre-filter photons in PhotonGBTFilter validator #254

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix: add FD cut for pre-filter photons in PhotonGBTFilter validator #254

merged 1 commit into from
Jul 19, 2024

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Jul 18, 2024 •
edited
Loading

This is the last fix we need for #244. PhotonGBTFilter already applies this cut, so the validator needs to also apply this cut to the unfiltered photons.

@c-dilks c-dilks requested a review from Gregtom3 as a code owner July 18, 2024 17:11
@c-dilks c-dilks enabled auto-merge (squash) July 18, 2024 17:11
@c-dilks c-dilks linked an issue Jul 18, 2024 that may be closed by this pull request
Spikes in distributions produced by validators #244
Closed
@c-dilks c-dilks merged commit 05347b2 into main Jul 19, 2024
43 checks passed
@c-dilks c-dilks deleted the fix-gbt-spike branch July 19, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gregtom3 Gregtom3 Gregtom3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Iguana
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spikes in distributions produced by validators
2 participants
@c-dilks @Gregtom3