-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sector Finder: Support for charged & neutral particles, added action function and validator #243
Conversation
@c-dilks not sure why the CI is failing, sorry |
looks like a transient |
Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also make the action function's docstring clear to a new user (who may not want to read the code example, which I think is clear enough).
Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
Ok, thanks for the suggestions! |
Ignore macOS CI failures, since the ROOT auto re-build over the weekend failed reproducibly. |
Before this pull request the config file was set up to take the same bank to find sector for charged and uncharged particles. This is problematic because the natural choice for charged particles (DC) is different from neutrals (calorimeters). SectorFinder also needed an action function and a validator
This pulls request introduces: