Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZVertexFilter: Added option for pids and validator #242

Merged

Conversation

rtysonCLAS12
Copy link
Contributor

Simple fix to add pids of particles for which to filter based on zvertex. Added default to only electrons in Config.yaml.

Also added validator to plot before and after zvertex cuts. This is plotted for electrons, on which we cut in the validator, but also other particles which shouldn't (and aren't) cut on.

Example plots for electrons and pions outputted by validator:
image
image

@rtysonCLAS12 rtysonCLAS12 requested a review from c-dilks as a code owner July 8, 2024 21:22
@rtysonCLAS12 rtysonCLAS12 linked an issue Jul 8, 2024 that may be closed by this pull request
@rtysonCLAS12 rtysonCLAS12 changed the title Added option for pids and validator ZVertexFilter: Added option for pids and validator Jul 9, 2024
@rtysonCLAS12
Copy link
Contributor Author

Thanks Chris for fixing the example files and fortran bindings, I had missed those in the original commit

@rtysonCLAS12
Copy link
Contributor Author

@c-dilks I've added the changes you recommended

@c-dilks
Copy link
Member

c-dilks commented Jul 11, 2024

Looking at the CI artifacts, any idea why there is a large spike here?
2024-07-11-141839_1417x1125_scrot

@rtysonCLAS12
Copy link
Contributor Author

That's strange, maybe something to do with how the vertex is calculated fro electrons in the FT? The plots for the other particle types seem sensible.

@c-dilks c-dilks merged commit f7eb567 into main Jul 11, 2024
44 checks passed
@c-dilks c-dilks deleted the 236-zvertex-filter-should-operate-on-specified-pids-only branch July 11, 2024 22:26
@dglazier
Copy link
Contributor

That's strange, maybe something to do with how the vertex is calculated fro electrons in the FT? The plots for the other particle types seem sensible.

Makes sense, there is no z-vertex position from the FT (no tracker). FT electrons should not have a z-vertex cut applied.

@rtysonCLAS12
Copy link
Contributor Author

That's strange, maybe something to do with how the vertex is calculated fro electrons in the FT? The plots for the other particle types seem sensible.

Makes sense, there is no z-vertex position from the FT (no tracker). FT electrons should not have a z-vertex cut applied.

Ok thanks for pointing that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ZVertex Filter should operate on specified PIDs only
3 participants