fix: treat warnings as errors and fix them #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent warnings (which can be real issues) from slipping through the cracks, build with `-werror`, so CI jobs fail if there are warnings. This is not the default build option, so that developers can still make test builds if there are warnings.
Fixes warnings
```
In file included from ../iguana_src/src/iguana/algorithms/clas12/PhotonGBTFilter/Algorithm.cc:1:
../iguana_src/src/iguana/algorithms/clas12/PhotonGBTFilter/Algorithm.h:130:32: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
130 | {{5032, 5332, 1}, [this](std::vector<float> const &data) { return ApplyCatboostModel_RGA_inbending_pass1(data); }}, // Fall2018 RGA Inbending
| ^~~~
```
(for some reason, they only appear with certain sanitizers...)
PhotonGBTFilter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent warnings (which can be real issues) from slipping through the cracks, build with
-werror, so CI jobs fail if there are warnings. This is not the default build option, so that developers can still make test builds if there are warnings.Fixed the following warnings:
PhotonGBTFiltersprintfdeprecation