Skip to content

Commit

Permalink
fix: assign $HIPO
Browse files Browse the repository at this point in the history
  • Loading branch information
c-dilks committed Dec 25, 2023
1 parent 4e43cf5 commit a46ee2c
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 2 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -241,10 +241,16 @@ jobs:
run: |
ls *.tar.gz | xargs -I{} tar xzvf {}
rm -v *.tar.gz
- name: set HIPO env vars
run: |
hipodir=$(pwd)/hipo
echo CMAKE_PREFIX_PATH=${hipodir} >> $GITHUB_ENV
if [ "${{ matrix.tool }}" = "make" ]; then
echo HIPO=${hipodir} >> $GITHUB_ENV
fi
- name: build and run
run: |
source iguana/bin/this_iguana.sh
export CMAKE_PREFIX_PATH="'"$(pwd)/hipo"'"
.github/test-dependent-build.sh ${{ matrix.tool }} test_data.hipo 1
# documentation
Expand Down
3 changes: 2 additions & 1 deletion bind/python/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ Then install packages with:
```bash
pip install -r bind/python/requirements.txt
```
**Note**: If you get an error stating that `"Python.h"` cannot be found, you need to install Python development headers and static libraries; depending on your OS and package manager, the relevant package to install is something like `python3-dev` or `python3-devel`.
- **Note**: If you get an error stating that `"Python.h"` cannot be found, you need to install Python development headers and static libraries; depending on your OS and package manager, the relevant package to install is something like `python3-dev` or `python3-devel`.
- **Note**: These bindings may not work for Python versions below 3.10

## Building the Python Bindings
Use the `--python` option when running `configure.py`, or edit your `build-iguana.ini` file
Expand Down
4 changes: 4 additions & 0 deletions meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ dep_include_paths = []
dep_pkg_config_paths = []
# cmake dependency libraries and headers
# FIXME: prefer `dep.get_variable(cmake: 'VARIABLE_NAME')`, but not sure if the needed variables are available...
# - if HIPO had a pkg-config file, we could:
# - get rid of this `cmake_prefix_path` loop and move `hipo_dep` into the `get_variable` loop
# - replace `$HIPO` in the Makefile example with a pkg-config command
# - remove `$HIPO` assignment in the Makefile CI job description
foreach path : get_option('cmake_prefix_path')
dep_lib_paths += path / 'lib'
dep_include_paths += path / 'include'
Expand Down

0 comments on commit a46ee2c

Please sign in to comment.