Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<LoadingButton> was removed in Nova 4 #92

Closed
ralphschindler opened this issue Nov 7, 2023 · 2 comments · Fixed by #93
Closed

<LoadingButton> was removed in Nova 4 #92

ralphschindler opened this issue Nov 7, 2023 · 2 comments · Fixed by #93
Labels
released

Comments

@ralphschindler
Copy link

Conversation here: laravel/nova-issues#6025
@alancolant alancolant mentioned this issue Nov 7, 2023
Merged
@alancolant
Copy link
Contributor

I've created a PR here, some nova packages are affected

JeffBeltran pushed a commit that referenced this issue Nov 20, 2023
@alancolant
fix: reintroduce LoadingButton component to fix creation modal subm…
92b1577 
…ission

This PR addresses the issue where the removal of `LoadingButton` since Nova 4.28 prevented submission in the creation modal. The component has been restored under a new name, resolving issue #92.
github-actions bot pushed a commit that referenced this issue Nov 20, 2023
@semantic-release-bot
chore(release): 2.0.4 [skip ci]
870549e 
## [2.0.4](v2.0.3...v2.0.4) (2023-11-20)

### Bug Fixes

* reintroduce `LoadingButton` component to fix creation modal submission ([92b1577](92b1577)), closes [#92](#92)
@JeffBeltran JeffBeltran linked a pull request Nov 20, 2023 that will close this issue
fix: LoadingButton removed from nova core #93
Merged
@JeffBeltran
Copy link
Owner

Closing as it should have been resolved with releases https://github.com/JeffBeltran/sanctum-tokens/releases/tag/v2.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: LoadingButton removed from nova core alancolant/laravel-fix-sanctum-tokens
3 participants
@ralphschindler @alancolant @JeffBeltran