Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearableValue option for Multi-Select #620

Merged
merged 2 commits into from
Dec 15, 2015
Merged

Add clearableValue option for Multi-Select #620

merged 2 commits into from
Dec 15, 2015

Conversation

slybridges
Copy link
Contributor

Fixes #458

@slybridges
Copy link
Contributor Author

On this PR I've added a note in the README that the clearableValue should only be used along with the clearable prop set to false.

This is because if we want not to clear the options that have clearableValue=false when pressing the Clear Allbutton, we have to iterate over each valueArray all the time which I felt could have some perf issues.

@slybridges
Copy link
Contributor Author

@JedWatson - anything you'd need from me to get this merged ?

@JedWatson
Copy link
Owner

Sorry for the delay @slybridges - this looks great, I'm merging it now.

JedWatson added a commit that referenced this pull request Dec 15, 2015
Add clearableValue option for Multi-Select
@JedWatson JedWatson merged commit 74edb9d into JedWatson:master Dec 15, 2015
@slybridges
Copy link
Contributor Author

👍 @JedWatson.
No worries for the delay, I understand open source can be tough on you sometimes ;)

@shivamjjha
Copy link

Seems this is removed in latest version of react-select ?
https://codesandbox.io/s/codesandboxer-example-forked-pn5c9c?file=/example.tsx

@vivekrekhadia
Copy link

Seems this is removed in latest version of react-select ? https://codesandbox.io/s/codesandboxer-example-forked-pn5c9c?file=/example.tsx

How you solved it then, I am having the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Disabling removal of items in multiselect
4 participants