-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove OptionBase type #4702
Remove OptionBase type #4702
Conversation
🦋 Changeset detectedLatest commit: ce9d4c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ce9d4c0:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Methuselah96
Resolves #4696.
Unfortunately due to weak type detection, it doesn't work to have an
Option
generic type that doesn't have any properties in common withOptionBase
since all of the properties onOptionBase
are optional. See the attached issue for a more concrete example that causes issues.