Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling issues #3633

Closed
wants to merge 33 commits into from
Closed

Fix scrolling issues #3633

wants to merge 33 commits into from

Conversation

vadimka123
Copy link
Contributor

@releaf
Copy link

releaf commented Jun 28, 2019

@JedWatson - It would be awesome to have this fix merged in.

@CuongLai
Copy link

@JedWatson I agree with @releaf - would really help me out to have this fix merged in.

@changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2019

⚠️ No Changeset found

Latest commit: ff36fb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vadimka123
Copy link
Contributor Author

@JedWatson, any update?

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ff36fb4:

Sandbox Source
react-codesandboxer-example Configuration

@shivam-kantival-mt
Copy link

@JedWatson, any updates on this?

@bladey bladey added pr/needs-review PRs that need to be reviewed to determine outcome pr/priority PRs that should be addressed sooner rather than later labels May 26, 2020
@bladey bladey added pr/bug-fix PRs that are specifically addressing a bug and removed pr/priority PRs that should be addressed sooner rather than later labels Jun 4, 2020
@prajjawalagarwal
Copy link

@JedWatson @vadimka123 we are also facing this scrolling issue. Any updates on when can this be merged into master?

@jasveer1997
Copy link

jasveer1997 commented Jul 27, 2020

@vadimka123 I think the proposed solution does not work correctly(needs a minor change) for the following case:
For me, it was fetching data correctly only for the first time. Then, I had to drag scrollbar up, leave it, and scroll down again. (was not working if I again directly drag the scrollbar down to bottom)
Therefore, I have to to add this.handleEventDelta(event, 1) in the onMouseDown fn, to reset isBottom prop in handleEventDeltaback to false. (this resetting happens for scroll automatically by onWheel).

@bladey bladey added pr/needs-review PRs that need to be reviewed to determine outcome and removed pr/needs-review PRs that need to be reviewed to determine outcome labels Aug 24, 2020
@aron-hivebrite
Copy link

Hello @vadimka123,
Firstly, thanks for your work.
I have tested your solution but I still see a bug when I use the react-select on a mobile and using a modal, I cannot scroll the options.
I have modified an existing code in codesandboxer to show you the bug:
https://codesandbox.io/s/react-codesandboxer-example-forked-vmhpl?file=/index.js
Could you check it please?
Thanks in advance.

@aron-hivebrite
Copy link

Hello @vadimka123,
Thanks for you update. Did you verify the tests failed on CircleCI please?
I am very interested to test your last update.
Thanks in advance.

@vadimka123
Copy link
Contributor Author

Hi, @aron-hivebrite
I checked issue with react-select 3.1.0
It's have same issue and looks like not related to my changes
You also can check here: https://codesandbox.io/s/react-codesandboxer-example-forked-12n5d
Most likely existing touch events damage this

@Methuselah96
Copy link
Collaborator

Methuselah96 commented Nov 14, 2020

I've started a fork of react-select. Feel free to resubmit this PR on the fork and we can get it merged and released.

EDIT: 🎉 I've archived the fork now that we've got some momentum in this repo and Jed is involved again. Sorry for the disturbance!

@ebonow ebonow added the menu-bug Addresses menu positioning, scrolling, or general interactions label Jan 16, 2021
@vadimka123 vadimka123 closed this Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
menu-bug Addresses menu positioning, scrolling, or general interactions pr/bug-fix PRs that are specifically addressing a bug pr/needs-review PRs that need to be reviewed to determine outcome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants