Fixed crash when the scrollTarget is undefined in ScrollCaptor #3419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following crash in react-select 2.3.0:
The crash produced because of the following code:
in class ScrollCaptor which is expected to set this.scrollTarget before componentDidMount from ScrollCaptor is called. But NodeResolver calls this.props.innerRef function also in componentDidMount so there is sometimes a time race condition triggered. And it let this.getScrollTarget undefined when componentDidMount from ScrollCaptor executes this.startListening(this.scrollTarget)
The workaround to this crash is to set the props captureMenuScroll={false} of Select as the default value is true because of
captureMenuScroll boolean = !isTouchCapable()