Relax placeholder propType from string to Node

JedWatson · Mar 12, 2019 · 7c3f967 · 7c3f967
1 parent 71df767
commit 7c3f967
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/Select.js b/src/Select.js
@@ -226,8 +226,8 @@ export type Props = {
   options: OptionsType,
   /* Number of options to jump in menu when page{up|down} keys are used */
   pageSize: number,
-  /* Placeholder text for the select value */
-  placeholder: string,
+  /* Placeholder for the select value */
+  placeholder: Node,
   /* Status to relay to screen readers */
   screenReaderStatus: ({ count: number }) => string,
   /*

diff --git a/src/__tests__/Select.test.js b/src/__tests__/Select.test.js
@@ -1835,12 +1835,18 @@ cases(
   },
   {
     'single select > should display default placeholder "Select..."': {},
-    'single select > should display provided placeholder': {
+    'single select > should display provided string placeholder': {
       props: {
         placeholder: 'single Select...',
       },
       expectPlaceholder: 'single Select...',
     },
+    'single select > should display provided node placeholder': {
+      props: {
+        placeholder: <span>single Select...</span>,
+      },
+      expectPlaceholder: 'single Select...',
+    },
     'multi select > should display default placeholder "Select..."': {},
     'multi select > should display provided placeholder': {
       props: {