Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusing AgrumeViewController instance #33

Closed
broadwaylamb opened this issue Aug 22, 2016 · 2 comments
Closed

Reusing AgrumeViewController instance #33

broadwaylamb opened this issue Aug 22, 2016 · 2 comments
Labels

Comments

@broadwaylamb
Copy link
Contributor

broadwaylamb commented Aug 22, 2016

When used Swift 2.2 I could once initialize a property agrume in my view controller so that when I opened Agrume somewhere inside that view controller via showFrom(_:) I could access to that property without instantiating a new Agrume view controller. It used to work well until I migrated to Swift 3 and Xcode 8.

Now when I use this scenario weird things happen, Agrume seems to be shown, but it is invisible (shown in visual debugger though).

BUT when I switched to a different scenario (instantiating a new Agrume view controller), everything worked as expected.

So, the question is, is Agrume designed in a way such that I have to create a new instance every time I want to open it?

broadwaylamb added a commit to lanit-tercom-school/grouplock that referenced this issue Aug 23, 2016
@JanGorman
Copy link
Owner

Thanks for reporting this – there's nothing that speaks against having just one instance and re-using that. I will take a look

@JanGorman
Copy link
Owner

Sorry this took so long. The latest commit to the 3.0 branch fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants