Separate data generation step #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You should be able to run with: ``` mitosis ode_data -e ode_data.seed=1 ... ```
Now that data generation fits the mitosis API, make odes.run and pdes.run accept their data as input. Gridsearch handles them separately as well. Also fix fitting with t_train/dt
yb6599
reviewed
Sep 24, 2024
| model = make_model(input_features, dt, diff_params, feat_params, opt_params) | ||
|
|
||
| model.fit(x_train) | ||
| model.fit(x_train, t=dt) |
There was a problem hiding this comment.
It should be t=t_train instead of t=dt, right?
src/gen_experiments/data.py
Outdated
There was a problem hiding this comment.
Alright, I understand how it should have been done instead of how I did it. Thanks, this is much more simpler than what I've done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
gen_dataorgen_pde_datafrom the ODE/PDE experiments, making it a fully-fledged experiment step. gridsearch now has to dispatch the data params to the correct data generation method. These methods are hollowed out and simply handle default parameters/lookups/guard code, with the actual data generation extracted to helper functions.