Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PDE experiment code into main #26

Merged
merged 9 commits into from
May 22, 2024
Merged

Conversation

yb6599
Copy link
Collaborator

@yb6599 yb6599 commented May 13, 2024

This change contains modifications to the PDE plotting functions, the initial conditions and spatial grids for better PDE solving, removes the use of identity and quadratic functions and introduces better function library terms.

@Jacob-Stevens-Haas
Copy link
Owner

Please summarize the changes in the first comment. The title should also be more than just the name of the branch.

You also need to resolve these conflicts the correct way. We can do this tomorrow if you have questions

@yb6599 yb6599 changed the title Default pde ex Merge PDE experiment code into main May 14, 2024
Copy link
Owner

@Jacob-Stevens-Haas Jacob-Stevens-Haas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plotting functions go in gen_experiemnts/plotting.py

@yb6599
Copy link
Collaborator Author

yb6599 commented May 21, 2024

LGTM

@Jacob-Stevens-Haas Jacob-Stevens-Haas merged commit cd41957 into main May 22, 2024
5 checks passed
@Jacob-Stevens-Haas Jacob-Stevens-Haas deleted the default-pde-ex branch May 22, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants