Make change how grid indexing tuples are saved so that find_gridpoints() finds anything
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There has been some ambiguity about what index is stored in gridsearch results. Previously, GridsearchResult contained the indexes of the optimal result in the full series gridsearch array, which included an index of the metric as well as the indexes to uniquely identify parameters at the gridpoint. However, the SavedGridPoint objects obviously only knew their parameter indexes, rather than all carrying around indexes for every metric (which would be identical across every point). Now, early in gridsearch, the metric index is lost, meaning that every GridsearchResult will store indexing tuples for the optimal results that align with parameter indexes. Also, rename np_to_primitive()
|
LGTM. I'll start running the experiments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #21. I'm going to leave that open after this PR to address some of the thornier questions this issue raises: the opportunity for spurious matches. This PR also fixes an unrelated bug in
find_gridpoints()TL;DR: @yb6599 the experiments you were running should work now.