Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Reversing File Post Order #366

Merged
merged 27 commits into from
Oct 27, 2023
Merged

Conversation

TheMarstonConnell
Copy link
Member

Reversing file post order from providers -> users to users -> providers.

A part of v4 (#365).

x/storage/types/active_deals.pb.go Fixed Show fixed Hide fixed
x/storage/types/active_deals.pb.go Fixed Show fixed Hide fixed
@TheMarstonConnell TheMarstonConnell self-assigned this Oct 20, 2023
@TheMarstonConnell TheMarstonConnell marked this pull request as ready for review October 26, 2023 15:04
@TheMarstonConnell TheMarstonConnell changed the base branch from v4.x.x to master October 26, 2023 15:04
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 503 lines in your changes are missing coverage. Please review.

Comparison is base (9d30aa5) 47.80% compared to head (9c3484a) 44.32%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   47.80%   44.32%   -3.48%     
==========================================
  Files         242      232      -10     
  Lines        9027     8600     -427     
==========================================
- Hits         4315     3812     -503     
- Misses       4429     4550     +121     
+ Partials      283      238      -45     
Files Coverage Δ
app/app.go 91.92% <ø> (+0.51%) ⬆️
x/storage/keeper/grpc_query_attestation.go 28.94% <100.00%> (+6.09%) ⬆️
x/storage/keeper/grpc_query_report.go 28.94% <100.00%> (+6.09%) ⬆️
x/storage/keeper/msg_server_provider_claim.go 93.61% <100.00%> (ø)
x/storage/keeper/reports.go 100.00% <100.00%> (ø)
x/storage/types/genesis.go 83.33% <100.00%> (-7.15%) ⬇️
x/storage/keeper/migrations.go 0.00% <0.00%> (ø)
x/storage/types/key_providers.go 28.57% <0.00%> (+8.57%) ⬆️
x/storage/keeper/utils.go 59.09% <57.14%> (-21.33%) ⬇️
x/storage/keeper/attestations.go 73.33% <76.47%> (-26.67%) ⬇️
... and 21 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheMarstonConnell TheMarstonConnell added the enhancement New feature or request label Oct 26, 2023
@TheMarstonConnell
Copy link
Member Author

Test coverage is failing. We will bump that up later, this push is to create a foundation for other PRs to build on, such as econ v2 and file tree updates.

@TheMarstonConnell TheMarstonConnell changed the title Reversing File Post Order v4: Reversing File Post Order Oct 26, 2023
Copy link
Member

@dahn510 dahn510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump go version in makefile from 1.20 to 1.21?

x/storage/client/cli/query_attest.go Outdated Show resolved Hide resolved
Copy link
Member

@dahn510 dahn510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TheMarstonConnell TheMarstonConnell merged commit 9e0520e into master Oct 27, 2023
9 of 11 checks passed
@TheMarstonConnell TheMarstonConnell deleted the marston/reverse-claim branch October 27, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants