Merge pull request oneapi-src#1655 from npmiller/hip-skip-spec-cst

[CTS] Skip spec constants tests for HIP
JackAKirk · May 24, 2024 · 4d16a65 · 4d16a65
2 parents d5166d5 + d46c214
commit 4d16a65
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/test/conformance/program/program_adapter_hip.match b/test/conformance/program/program_adapter_hip.match
@@ -25,4 +25,6 @@ urProgramBuildTest.BuildFailure/AMD_HIP_BACKEND___{{.*}}_
 {{OPT}}urProgramGetInfoTest.InvalidNullHandleProgram/AMD_HIP_BACKEND___{{.*}}___UR_PROGRAM_INFO_KERNEL_NAMES
 {{OPT}}urProgramLinkTest.Success/AMD_HIP_BACKEND___{{.*}}_
 {{OPT}}urProgramSetSpecializationConstantsTest.Success/AMD_HIP_BACKEND___{{.*}}_
-{{OPT}}{{Segmentation fault|Aborted}}
+{{OPT}}urProgramSetSpecializationConstantsTest.UseDefaultValue/AMD_HIP_BACKEND___{{.*}}_
+{{OPT}}urProgramSetMultipleSpecializationConstantsTest.MultipleCalls/AMD_HIP_BACKEND___{{.*}}_
+{{OPT}}urProgramSetMultipleSpecializationConstantsTest.SingleCall/AMD_HIP_BACKEND___{{.*}}_
diff --git a/test/conformance/program/urProgramSetSpecializationConstants.cpp b/test/conformance/program/urProgramSetSpecializationConstants.cpp
@@ -48,9 +48,10 @@ TEST_P(urProgramSetSpecializationConstantsTest, UseDefaultValue) {
     ASSERT_SUCCESS(urPlatformGetInfo(platform, UR_PLATFORM_INFO_BACKEND,
                                      sizeof(ur_platform_backend_t), &backend,
                                      nullptr));
-    if (backend == UR_PLATFORM_BACKEND_CUDA) {
-        GTEST_FAIL()
-            << "This test is known to cause crashes on Nvidia; not running.";
+    if (backend == UR_PLATFORM_BACKEND_CUDA ||
+        backend == UR_PLATFORM_BACKEND_HIP) {
+        GTEST_FAIL() << "This test is known to cause crashes on Nvidia and "
+                        "AMD; not running.";
     }
 
     ASSERT_SUCCESS(urProgramBuild(context, program, nullptr));