Add new page for Custom Themes [advanced] for 5.2 (dev) #324 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
koppor
reviewed
Nov 5, 2020
There was a problem hiding this comment.
Short, but good enough. Could you fix the markdown lint issues?
en/advanced/customthemes.md:1 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "# Custom Themes"]
en/advanced/customthemes.md:2 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## General"]
en/advanced/customthemes.md:9 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Selection of Useful CSS selectors"]
en/advanced/customthemes.md:16 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Examples"]
(Reason for linting: I want to have all markdown files in this repository to look the same way. This IMHO enables better maintenance)
|
Done! |
|
Do we still have those since version xxx headers or a way to mark the content for a specific version? |
Siedlerchr
approved these changes
Nov 7, 2020
|
Think, the version headers are gone with the migration to GitBook refs #178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created pages for Custom Themes according to #324