Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the INSPIREFetcher in "Update with bibliographic information from the web" #9645

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

YANG-XingYu
Copy link
Contributor

Improve #9602

Normally, one can fetch information of new arXiv paper in the INSPIRE database, but this entry doesn't have doi in the INSPIRE database because it is preprint and hasn't been published in journal.
After some time, the paper gets published, if one wants to update the entry through "Update with bibliographic information from the web", then doi is unavailable.
So I added a fetcher with arXiv ID.
In addition, I added the post cleanup to keep the consistency between SearchBasedParserFetcher and EntryBasedFetcher.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

Thanks for the contribution! I think that's a good idea!.
can you please take a look at the INSPIREFetcherTest as well?
It currently fails (you can ignore the other not related fetcher test)


org.jabref.logic.importer.fetcher.INSPIREFetcherTest searchByExistingEntry() FAILED

  org.opentest4j.AssertionFailedError: expected: <[@article{Melnikov:1998pr,
    archiveprefix = {arXiv},
    author = {Melnikov, Kirill and Yelkhovsky, Alexander},
    doi = {10.1016/S0550-3213(98)00348-4},
    eprint = {hep-ph/9802379},
    journal = {Nucl. Phys. B},
    pages = {59--72},
    reportnumber = {BUDKER-INP-1998-7, TTP-98-10},
    title = {{Top quark production at threshold with O(alpha-s**2) accuracy}},
    volume = {528},
    year = {1998},
    _jabref_shared = {sharedId: -1, version: 1}
  }]> but was: <[@article{Melnikov:1998pr,
    archiveprefix = {arXiv},
    author = {Melnikov, Kirill and Yelkhovsky, Alexander},
    doi = {10.1016/S0550-3213(98)00348-4},
    eprint = {hep-ph/9802379},
    journal = {Nucl. Phys. B},
    pages = {59--72},
    reportnumber = {BUDKER-INP-1998-7, TTP-98-10},
    title = {Top quark production at threshold with O(alpha-s**2) accuracy},
    volume = {528},
    year = {1998},
    _jabref_shared = {sharedId: -1, version: 1}
  }]>

@Siedlerchr Siedlerchr added the status: changes required Pull requests that are not yet complete label Mar 1, 2023
arXiv now has its own doi such as "10.48550/arXiv.2303.xxxxx", but this
doi cannot be recognized by INSPIRE.
@YANG-XingYu
Copy link
Contributor Author

I didn't touch the INSPIREFetcherTest in the last commit.
I found the failure of this test is due to the redundant brace in the title field, so I just removed it.

@Siedlerchr
Copy link
Member

Siedlerchr commented Mar 3, 2023 via email

@Siedlerchr Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: changes required Pull requests that are not yet complete labels Mar 3, 2023
@calixtus calixtus merged commit ee93bfb into JabRef:main Mar 6, 2023
Siedlerchr added a commit that referenced this pull request Mar 14, 2023
…rg.mariadb.jdbc-mariadb-java-client-3.1.0

* upstream/main: (357 commits)
  Fix syntax
  Add experimental Fetcher for Bibliotheksverbund Bayern with MarcXML parser (#9641)
  Update guidelines-for-setting-up-a-local-workspace.md
  Update guidelines-for-setting-up-a-local-workspace.md
  Bump org.tinylog:slf4j-tinylog from 2.6.0 to 2.6.1 (#9665)
  Bump apple-actions/import-codesign-certs from 1 to 2 (#9662)
  Bump com.puppycrawl.tools:checkstyle from 10.8.0 to 10.8.1 (#9661)
  Bump gittools/actions from 0.9.15 to 0.10.2 (#9663)
  Bump hmarr/auto-approve-action from 3.1.0 to 3.2.0 (#9664)
  Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 (#9666)
  Bump org.tinylog:tinylog-api from 2.6.0 to 2.6.1 (#9667)
  Add option to open arks in the browser from an ark identifier (#9601)
  remove "jdk 19 does not work" (#9658)
  Fulltext fetcher for IACR eprints (#9651)
  Observable Preferences S (#9619)
  Issue 9646: Right-click context menu "Attach file from URL" (#9648)
  Improve the INSPIREFetcher in "Update with bibliographic information from the web" (#9645)
  Bump appleboy/ssh-action from 0.1.7 to 0.1.8 (#9653)
  Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 (#9656)
  Bump com.puppycrawl.tools:checkstyle from 10.7.0 to 10.8.0 (#9655)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants