-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the INSPIREFetcher in "Update with bibliographic information from the web" #9645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the contribution! I think that's a good idea!.
|
arXiv now has its own doi such as "10.48550/arXiv.2303.xxxxx", but this doi cannot be recognized by INSPIRE.
I didn't touch the INSPIREFetcherTest in the last commit. |
Thanks! That was probably because you added the missing post cleanup.
That's good then
YANG-XingYu ***@***.***> schrieb am Fr., 3. März 2023, 05:59:
… I didn't touch the INSPIREFetcherTest in the last commit.
I found the failure of this test is due to the redundant brace in the
title field, so I just removed it.
—
Reply to this email directly, view it on GitHub
<#9645 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACOFZHCSRE7KVRKKBKFK5TW2F3C5ANCNFSM6AAAAAAVLWGBUI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Siedlerchr
approved these changes
Mar 3, 2023
calixtus
approved these changes
Mar 6, 2023
Siedlerchr
added a commit
that referenced
this pull request
Mar 14, 2023
…rg.mariadb.jdbc-mariadb-java-client-3.1.0 * upstream/main: (357 commits) Fix syntax Add experimental Fetcher for Bibliotheksverbund Bayern with MarcXML parser (#9641) Update guidelines-for-setting-up-a-local-workspace.md Update guidelines-for-setting-up-a-local-workspace.md Bump org.tinylog:slf4j-tinylog from 2.6.0 to 2.6.1 (#9665) Bump apple-actions/import-codesign-certs from 1 to 2 (#9662) Bump com.puppycrawl.tools:checkstyle from 10.8.0 to 10.8.1 (#9661) Bump gittools/actions from 0.9.15 to 0.10.2 (#9663) Bump hmarr/auto-approve-action from 3.1.0 to 3.2.0 (#9664) Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 (#9666) Bump org.tinylog:tinylog-api from 2.6.0 to 2.6.1 (#9667) Add option to open arks in the browser from an ark identifier (#9601) remove "jdk 19 does not work" (#9658) Fulltext fetcher for IACR eprints (#9651) Observable Preferences S (#9619) Issue 9646: Right-click context menu "Attach file from URL" (#9648) Improve the INSPIREFetcher in "Update with bibliographic information from the web" (#9645) Bump appleboy/ssh-action from 0.1.7 to 0.1.8 (#9653) Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 (#9656) Bump com.puppycrawl.tools:checkstyle from 10.7.0 to 10.8.0 (#9655) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve #9602
Normally, one can fetch information of new arXiv paper in the INSPIRE database, but this entry doesn't have doi in the INSPIRE database because it is preprint and hasn't been published in journal.
After some time, the paper gets published, if one wants to update the entry through "Update with bibliographic information from the web", then doi is unavailable.
So I added a fetcher with arXiv ID.
In addition, I added the post cleanup to keep the consistency between SearchBasedParserFetcher and EntryBasedFetcher.
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)