Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storing multiline properties for custom fields in custom entry types #9620

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Fix storing multiline properties for custom fields in custom entry types #9620

merged 1 commit into from
Feb 16, 2023

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Feb 14, 2023 •
edited
Loading

Fixes #9609

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 14, 2023
calixtus
calixtus reviewed Feb 16, 2023
View reviewed changes
src/main/java/org/jabref/model/entry/field/UnknownField.java
@@ -47,7 +54,7 @@ public int hashCode() {
@Override
public String toString() {
return "UnknownField{" +
"name='" + name + '\'' +
'}';
"name='" + name + '\'' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one ' is escaped, the other not, because of surrounding double quotes. technically correct, but it hurts my eyes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably auto generated by the IDE(A)

@Siedlerchr Siedlerchr merged commit 98c9cbb into main Feb 16, 2023
@Siedlerchr Siedlerchr deleted the fixMultilineForCustomFields branch February 16, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom entry types: Mulitline option not working
2 participants
@Siedlerchr @calixtus