Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snap launcher config #9269

Merged
merged 1 commit into from
Oct 22, 2022
Merged

Fix snap launcher config #9269

merged 1 commit into from
Oct 22, 2022

Conversation

tobiasdiez
Copy link
Member

Fix a few remaining spots that were referring to the old launcher config. Fixes #9264.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 19, 2022
@Siedlerchr
Copy link
Member

Siedlerchr commented Oct 20, 2022

I would wait with this until we fixed the mac global menu stuff. #9247

@Siedlerchr Siedlerchr merged commit 79a330e into main Oct 22, 2022
@Siedlerchr Siedlerchr deleted the jr-launcher-name branch October 22, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jabref snap fails to open after update
2 participants