Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for search history #8974

Closed
wants to merge 1 commit into from
Closed

Conversation

fenmaple
Copy link

@fenmaple fenmaple commented Jul 14, 2022

Fixes #7906

by adding History.java

This part of the contribution contains basic classes, which are used to save search history, record, modify and query search history.

The search history is added on the original basis, and the following functions are supported:

record search history
browse search history
query of specific search history
delete search history

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

add History.java for JabRef#7906
@ThiloteE
Copy link
Member

ThiloteE commented Jul 14, 2022

Thank you for your pull-request!

As a general feedback: To ease organizational workflows I have linked the pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

  • close
  • closes
  • closed
  • fix
  • fixes
  • fixed
  • resolve
  • resolves
  • resolved

If you use a keyword to reference a pull request comment in another pull request, the pull requests will be linked. Merging the referencing pull request also closes the referenced pull request.

The syntax for closing keywords depends on whether the issue is in the same repository as the pull request.

@ThiloteE ThiloteE changed the title Create History Adds support for search History Jul 16, 2022
@ThiloteE ThiloteE changed the title Adds support for search History Adds support for search history Jul 16, 2022
@koppor koppor marked this pull request as draft July 18, 2022 18:49
@calixtus
Copy link
Member

any update here?

@Siedlerchr
Copy link
Member

Closing this issue due to inactivity 💤
Please reopen the issue with additional information if the problem persists.

@Siedlerchr Siedlerchr closed this Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please record search history
4 participants