Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize pages in citavi to avoid unicode minus signs #8881

Merged
merged 2 commits into from
Jun 5, 2022
Merged

Normalize pages in citavi to avoid unicode minus signs #8881

merged 2 commits into from
Jun 5, 2022

Conversation

Siedlerchr
Copy link
Member

Follow up to #8848

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor
koppor reviewed Jun 1, 2022
View reviewed changes
src/main/java/org/jabref/logic/importer/fileformat/CitaviXmlImporter.java Outdated

String pages = clean(getPages(data));
// Cleans also unicode minus signs
pages = new NormalizePagesFormatter().format(pages);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, the lifecycle of our formatters is longer --> introduce the formatter as class variable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this up now as a field

@Siedlerchr Siedlerchr merged commit d827d17 into main Jun 5, 2022
@Siedlerchr Siedlerchr deleted the fixCitaviPagesCleanup branch June 5, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor left review comments

Assignees
No one assigned
Labels
component: import-load
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Siedlerchr @koppor @ThiloteE