Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed encoding used by IntegrityCheck #8359

Merged
merged 7 commits into from
Dec 25, 2021
Merged

Changed encoding used by IntegrityCheck #8359

merged 7 commits into from
Dec 25, 2021

Conversation

k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

@k3KAW8Pnf7mkmdSMPHz27 k3KAW8Pnf7mkmdSMPHz27 commented Dec 23, 2021

Fixes #8022.

Previous method used System.getProperty("file.encoding") to get the current character encoding).
Changed to use,

  1. bibDatabaseContext.getMetaData().getEncoding()
  2. preferencesService.getGeneralPreferences().getDefaultEncoding()

Todo:

  1. I don't think it can distinguish GBK from UTF-8
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Refs issue #5850 and PR #7639

@k3KAW8Pnf7mkmdSMPHz27 k3KAW8Pnf7mkmdSMPHz27 changed the title Fixed encoding used by IntegrityCheck Changed encoding used by IntegrityCheck Dec 25, 2021
@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member Author

I should be able to test it in a running version of JabRef on Windows latest Monday.

@k3KAW8Pnf7mkmdSMPHz27 k3KAW8Pnf7mkmdSMPHz27 marked this pull request as ready for review December 25, 2021 20:10
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 25, 2021
@calixtus calixtus merged commit cd0137f into main Dec 25, 2021
@calixtus calixtus deleted the fixes-8022 branch December 25, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Valid utf-8 title flagged as non utf-8 by check integrity
3 participants