Show preview also for available styles #8110
Conversation
|
Since you are at it, while looking at the code in the preview style, have you seen something that would explain #7860? |
|
@ThiloteE If you want to try this version, you can check the build here https://builds.jabref.org/pull/8110/merge/ |
|
The searchbar is wonderful though!! |
|
The index exception comes from the Richtextfx library and I think this is also why there is no preview shown when the right side is empty. |
|
I maybe have an idea for the index exception, reminder to myself, test deleting/null setting the content before replacing with new style content |
remove uncessary listener
|
I could not fix the issue with the index out of bounds need to wait for the new release of the richtextfx stuff. |
| this.viewModel = new PreviewTabViewModel(dialogService, preferencesService, taskExecutor, stateManager); | ||
|
|
||
| filteredPreviews = new FilteredList<>(viewModel.availableListProperty()); |
There was a problem hiding this comment.
Shouldn't this be in the viewModel?
There was a problem hiding this comment.
I adapted this from the Journal Tab...
There was a problem hiding this comment.
I'm flattered that you think my code is perfect, as I am... 😅 But I am still only human
* upstream/main: Don't throw exception when validating invalid paths (#8112) Bump jackson-dataformat-yaml from 2.12.5 to 2.13.0 Bump jackson-datatype-jsr310 from 2.12.5 to 2.13.0 Bump byte-buddy-parent from 1.11.15 to 1.11.18 Bump classgraph from 4.8.116 to 4.8.121 Bump checkstyle from 9.0 to 9.0.1 remove iso charset, website returns utf8 for icar comp sci only returns one result fix springer fetcher Fix computer science fetcher Squashed 'buildres/csl/csl-locales/' changes from 7a507fc008..495f888637 Squashed 'buildres/csl/csl-styles/' changes from 5facb37..3b00357 Update CHANGELOG.md snap: Use lzo compression & switch to core20 base
…eviewAvaiableStyles * upstream/previewAvaiableStyles: Fixed typos
* upstream/main: (149 commits) Add Tutorials for javafx lint Add changelot Open folder on mac and highlight file Add Tests to DoiCleanup (#8124) Improve Drag and Drop in Custom Entry types dialog (#8121) Show preview also for available styles (#8110) udpate to javafx 17.0.0.1 Don't throw exception when validating invalid paths (#8112) Bump jackson-dataformat-yaml from 2.12.5 to 2.13.0 Bump jackson-datatype-jsr310 from 2.12.5 to 2.13.0 Bump byte-buddy-parent from 1.11.15 to 1.11.18 Bump classgraph from 4.8.116 to 4.8.121 Bump checkstyle from 9.0 to 9.0.1 remove iso charset, website returns utf8 for icar comp sci only returns one result fix springer fetcher Fix computer science fetcher Squashed 'buildres/csl/csl-locales/' changes from 7a507fc008..495f888637 Squashed 'buildres/csl/csl-styles/' changes from 5facb37..3b00357 Update CHANGELOG.md snap: Use lzo compression & switch to core20 base ...
Fixes #8108
Theoretically works, but not when the right side (chosen styles) is empty
Now includes a search
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)