-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve user friendliness of automatically linked files #7484
Changes from 7 commits
64a6005
50e98a7
cbdcbc7
931e454
41c825f
6f9f5cb
134e945
cb1cb5e
aa5eea2
b0eb124
4d9a709
b5b42b0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -140,6 +140,7 @@ private static Node createFileDisplay(LinkedFileViewModel linkedFile) { | |
Node icon = linkedFile.getTypeIcon().getGraphicNode(); | ||
icon.setOnMouseClicked(event -> linkedFile.open()); | ||
Text link = new Text(); | ||
link.opacityProperty().bind(linkedFile.opacityProperty()); | ||
link.textProperty().bind(linkedFile.linkProperty()); | ||
link.getStyleClass().setAll("file-row-text"); | ||
Text desc = new Text(); | ||
|
@@ -157,7 +158,11 @@ private static Node createFileDisplay(LinkedFileViewModel linkedFile) { | |
Button acceptAutoLinkedFile = IconTheme.JabRefIcons.AUTO_LINKED_FILE.asButton(); | ||
acceptAutoLinkedFile.setTooltip(new Tooltip(Localization.lang("This file was found automatically. Do you want to link it to this entry?"))); | ||
acceptAutoLinkedFile.visibleProperty().bind(linkedFile.isAutomaticallyFoundProperty()); | ||
acceptAutoLinkedFile.setOnAction(event -> linkedFile.acceptAsLinked()); | ||
acceptAutoLinkedFile.managedProperty().bind(linkedFile.isAutomaticallyFoundProperty()); | ||
acceptAutoLinkedFile.setOnAction(event -> { | ||
linkedFile.acceptAsLinked(); | ||
linkedFile.setOpacityProperty(1.0); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move |
||
}); | ||
acceptAutoLinkedFile.getStyleClass().setAll("icon-button"); | ||
|
||
Button writeXMPMetadata = IconTheme.JabRefIcons.IMPORT.asButton(); | ||
|
@@ -169,7 +174,7 @@ private static Node createFileDisplay(LinkedFileViewModel linkedFile) { | |
HBox container = new HBox(10); | ||
container.setPrefHeight(Double.NEGATIVE_INFINITY); | ||
|
||
container.getChildren().addAll(info, acceptAutoLinkedFile, writeXMPMetadata); | ||
container.getChildren().addAll(acceptAutoLinkedFile, info, writeXMPMetadata); | ||
|
||
return container; | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -196,6 +196,7 @@ private List<LinkedFileViewModel> findAssociatedNotLinkedFiles(BibEntry entry) { | |
preferences.getFilePreferences(), | ||
externalFileTypes); | ||
newLinkedFile.markAsAutomaticallyFound(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move |
||
newLinkedFile.setOpacityProperty(0.3); | ||
result.add(newLinkedFile); | ||
} | ||
} catch (IOException e) { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1732,6 +1732,7 @@ Don't\ share=Don't share | |
Share\ anonymous\ statistics=Share anonymous statistics | ||
Telemetry\:\ Help\ make\ JabRef\ better=Telemetry: Help make JabRef better | ||
To\ improve\ the\ user\ experience,\ we\ would\ like\ to\ collect\ anonymous\ statistics\ on\ the\ features\ you\ use.\ We\ will\ only\ record\ what\ features\ you\ access\ and\ how\ often\ you\ do\ it.\ We\ will\ neither\ collect\ any\ personal\ data\ nor\ the\ content\ of\ bibliographic\ items.\ If\ you\ choose\ to\ allow\ data\ collection,\ you\ can\ later\ disable\ it\ via\ Options\ ->\ Preferences\ ->\ General.=To improve the user experience, we would like to collect anonymous statistics on the features you use. We will only record what features you access and how often you do it. We will neither collect any personal data nor the content of bibliographic items. If you choose to allow data collection, you can later disable it via Options -> Preferences -> General. | ||
(Auto)=(Auto) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is no longer needed, I guess. |
||
This\ file\ was\ found\ automatically.\ Do\ you\ want\ to\ link\ it\ to\ this\ entry?=This file was found automatically. Do you want to link it to this entry? | ||
Names\ are\ not\ in\ the\ standard\ %0\ format.=Names are not in the standard %0 format. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to the issue is not correct. Moreover, the changelog is for users, so please don't use technical terms such as LINK_PLUS.