Fix 6488 #6537
Fix 6488 #6537
Conversation
|
Welcome to JabRef development 🎉 . It is nice that the popup is having a better information. However, the popup should not appear! The user started with an empty database. He imports a single entry. This entry is added. Then, JabRef complains that a duplicate exists. This is really wired. Could you please invesitage JabRef's behavior: Why is there a duplicate check happening? I guess, it has to do something introduced with #6332, but I haven't checked. |
| boolean continueImport = dialogService.showConfirmationDialogWithOptOutAndWait(Localization.lang("Duplicates found"), | ||
| Localization.lang("There are possible duplicates (marked with an icon) that haven't been resolved. Continue?"), | ||
| //Localization.lang("There are possible duplicates (marked with an icon) that haven't been resolved. Continue?"), | ||
| Localization.lang(duplicateInfo.toString()), |
There was a problem hiding this comment.
This is unfortunately not how localization works. The string has to be directly passed to Localization.lang() as plain string. Use %0 as place holder.
There was a problem hiding this comment.
In my opinion, there are two cases that we need consider. First, the duplicate entry is in database. I think showing it's bibtexkey can help use find it quickly. Second, the duplicate entry is in the list entries that want to be imported. I think showing title is a better way because their bibtexkey is not shown in the import dialog. In a result, I have to concatenate string to meet different cases. So, do you have suggestion for this problem? Do I need revert this change?
| if (preferences.shouldWarnAboutDuplicatesForImport()) { | ||
| BackgroundTask.wrap(() -> entriesToImport.stream() | ||
| .anyMatch(this::hasDuplicate)).onSuccess(duplicateFound -> { | ||
| if (duplicateFound) { | ||
| StringBuffer duplicateInfo = new StringBuffer("There are possible duplicates (") ; | ||
| if (this.datasetDuplicate.isPresent()){ | ||
| duplicateInfo.append("duplicate to the entry in the database whose Bibtexkey is : "); |
There was a problem hiding this comment.
| duplicateInfo.append("duplicate to the entry in the database whose Bibtexkey is : "); | |
| duplicateInfo.append(Localization.lang("duplicate to the entry in the database whose Bibtexkey is: %0", this.datasetDuplicate.get().getField(InternalField.KEY_FIELD).get())); |
| duplicateInfo.append("duplicate to the entry in the database whose Bibtexkey is : "); | ||
| duplicateInfo.append(this.datasetDuplicate.get().getField(InternalField.KEY_FIELD).get()); | ||
| } | ||
| else if (this.internalDuplicate.isPresent()){ |
There was a problem hiding this comment.
Has to be on the same line as the }. -- Checkstyle will fail.
|
Long time no thinking about the issue. Sorry for that. I'll try to dive into it the next time. The underlying issue is more fundamental. See #6488 (comment). |
|
Closing this issue due to inactivity 💤 |
Fix #6488
In order to let duplicate information more clear, I hava make some changes.
When user imports some entries to a database:
(1) If these entries are duplicate to the entry in the database, it will shown the Bibtexkey of the duplicate entry in UI.
(2) If there are two entries are duplicate among the imported entries, it will shown the title of the duplicate entry.