Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ACM Fetcher #5805

Merged
merged 3 commits into from
Jan 2, 2020
Merged

Disable ACM Fetcher #5805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
266b3ac
Disable ACM Fetcher
koppor Jan 1, 2020
ed0e5ae
Adapt WebFetchersTest
koppor Jan 2, 2020
60dd9d5
Remove ACM Fetcher in one more check
koppor Jan 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/jabref/logic/importer/WebFetchers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import java.util.SortedSet;
import java.util.TreeSet;

import org.jabref.logic.importer.fetcher.ACMPortalFetcher;
import org.jabref.logic.importer.fetcher.ACS;
import org.jabref.logic.importer.fetcher.ArXiv;
import org.jabref.logic.importer.fetcher.AstrophysicsDataSystem;
Expand Down Expand Up @@ -90,7 +89,8 @@ public static SortedSet<SearchBasedFetcher> getSearchBasedFetchers(ImportFormatP
set.add(new AstrophysicsDataSystem(importFormatPreferences));
set.add(new MathSciNet(importFormatPreferences));
set.add(new ZbMATH(importFormatPreferences));
set.add(new ACMPortalFetcher(importFormatPreferences));
// see https://github.com/JabRef/jabref/issues/5804
// set.add(new ACMPortalFetcher(importFormatPreferences));
set.add(new GoogleScholar(importFormatPreferences));
set.add(new DBLPFetcher(importFormatPreferences));
set.add(new SpringerFetcher());
Expand Down
10 changes: 10 additions & 0 deletions src/test/java/org/jabref/logic/importer/WebFetchersTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import java.util.Set;
import java.util.stream.Collectors;

import org.jabref.logic.importer.fetcher.ACMPortalFetcher;
import org.jabref.logic.importer.fetcher.AbstractIsbnFetcher;
import org.jabref.logic.importer.fetcher.IsbnViaEbookDeFetcher;
import org.jabref.logic.importer.fetcher.IsbnViaOttoBibFetcher;
Expand Down Expand Up @@ -39,9 +40,14 @@ void getIdBasedFetchersReturnsAllFetcherDerivingFromIdBasedFetcher() throws Exce

expected.remove(AbstractIsbnFetcher.class);
expected.remove(IdBasedParserFetcher.class);

// Remove special ISBN fetcher since we don't want to expose them to the user
expected.remove(IsbnViaEbookDeFetcher.class);
expected.remove(IsbnViaOttoBibFetcher.class);

// Remove ACM, because it doesn't work currently
expected.remove(ACMPortalFetcher.class);

assertEquals(expected, getClasses(idFetchers));
}
}
Expand All @@ -68,6 +74,10 @@ void getSearchBasedFetchersReturnsAllFetcherDerivingFromSearchBasedFetcher() thr
Set<Class<?>> expected = controlClasses.loadClasses().stream().collect(Collectors.toSet());

expected.remove(SearchBasedParserFetcher.class);

// Remove ACM, because it doesn't work currently
expected.remove(ACMPortalFetcher.class);

assertEquals(expected, getClasses(searchBasedFetchers));
}
}
Expand Down
2 changes: 2 additions & 0 deletions src/test/java/org/jabref/logic/importer/fetcher/ACMPortalFetcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,15 @@
import org.jabref.testutils.category.FetcherTest;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

@FetcherTest
@Disabled("ACM endpoint does not work, thus the fetcher does not work at all. See https://github.com/JabRef/jabref/issues/5804 for details.")
class ACMPortalFetcherTest {
ACMPortalFetcher fetcher;

Expand Down