Improve column preference migration #5670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
reviewed
Nov 24, 2019
| private final DoubleProperty widthProperty = new SimpleDoubleProperty(ColumnPreferences.DEFAULT_WIDTH); | ||
| private final ObjectProperty<Type> typeProperty; | ||
| private final StringProperty qualifierProperty; | ||
| private final DoubleProperty widthProperty; | ||
|
|
||
| /** | ||
| * This is used by the preferences dialog, to initialize available columns the user can add to the table. | ||
| * | ||
| * @param type the {@code MainTableColumnModel.Type} of the column, e.g. "NORMALFIELD" or "GROUPS" | ||
| * @param qualifier the stored qualifier of the column, e.g. "author/editor" |
There was a problem hiding this comment.
Could you add a @param description for the width, too?
| widthProperty = new SimpleDoubleProperty(width); | ||
| } | ||
|
|
||
| public MainTableColumnModel(Type type, String qualifier) { |
There was a problem hiding this comment.
Can you copy the old JavaDoc to here?
There was a problem hiding this comment.
I don't see any value in copying the java doc, especially since this is a stupid constructor that does the obvious thing ;-)
| } | ||
|
|
||
| public MainTableColumnModel(Type type, double width) { | ||
| this(type, "", width); | ||
| } | ||
|
|
||
| public MainTableColumnModel(Type type) { |
There was a problem hiding this comment.
Can you copy the old JavaDoc to here and remove the qualifier parameter?
Siedlerchr
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5661.