Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE with bibdatabasecontext in preview style dialog #4278

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Fix NPE with bibdatabasecontext in preview style dialog #4278

merged 1 commit into from
Aug 20, 2018

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Aug 20, 2018 •
edited
Loading

Followup from #3765. I discovered an NPE with the bibdatabasecontext in the NewDroppedFileHandler.
The reason is that the move files cleanup operation requires a non null bibdatabasecontext and when calling the preview panel from the preferences, no context was there.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 20, 2018
@Siedlerchr Siedlerchr merged commit cf3fab8 into master Aug 20, 2018
@Siedlerchr Siedlerchr deleted the bibdatabasecontex branch August 20, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siedlerchr @tobiasdiez