Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent accidentaly deleting a second file when pressing del key #3927

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Prevent accidentaly deleting a second file when pressing del key #3927

merged 1 commit into from
Apr 4, 2018

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Apr 4, 2018 •
edited
Loading

Fixes #3926

The key listener was triggered twice (on pressed + released) resulting in the selection of the second file

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@Siedlerchr
Prevent accidentaly deleting a second file when pressing del key
030cb9a 
The key listener was triggered twice (on pressed + released) resulting in the selection of the second file
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 4, 2018
@Siedlerchr
Copy link
Member Author

As this is not even a one-liner and I tested the changes I merged them directly in.

@Siedlerchr Siedlerchr merged commit fe90b1a into master Apr 4, 2018
@Siedlerchr Siedlerchr deleted the fixdeletekeyevent branch April 4, 2018 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Siedlerchr