Pressing ESC while searching clears searchfield and selects first available entry #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
requested changes
Feb 21, 2018
|
|
||
| // Clears search on ESC & select first entry, if available | ||
| searchField.setOnKeyPressed((event -> { | ||
| if (event.getCode() == KeyCode.ESCAPE) { |
There was a problem hiding this comment.
The "Clear search" shortcut is customizable. Please use
to check for the correct key (using a KeyBindingRepository).
There was a problem hiding this comment.
Just take a look at the setupKeyBindings in the EntryEditor, we use that code in several other classes, too.
|
No activity. @tobiasdiez or @Siedlerchr please take over or just close this PR. |
tobiasdiez
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title describes, search field gets cleared when pressing the escape key during search and selects first available entry, this time using JavaFX.
Description already existent in CHANGELOG.md from earlier pull request (on older Swing platform).
Reference: #3747