Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix freezing when editing assigned file in General Tab #3079

Merged
merged 1 commit into from
Aug 6, 2017
Merged

Fix freezing when editing assigned file in General Tab #3079

merged 1 commit into from
Aug 6, 2017

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Aug 6, 2017 •
edited
Loading

Swing GUI was called from FXApplication Thread which lead to a freeze.
Has to be called in Swing Thread.

Fixes #2930 (comment)

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 6, 2017
@Siedlerchr Siedlerchr merged commit b7743c4 into master Aug 6, 2017
@Siedlerchr Siedlerchr deleted the fixFileEditorFree branch August 6, 2017 19:57
@Siedlerchr Siedlerchr mentioned this pull request Aug 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siedlerchr @tobiasdiez