Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selecting all entries with shortcut #2683

Merged
merged 4 commits into from
Apr 16, 2017
Merged

Fix selecting all entries with shortcut #2683

merged 4 commits into from
Apr 16, 2017

Conversation

chriba
Copy link
Contributor

@chriba chriba commented Mar 24, 2017

Fixes #2615

It seems that I was a bit too fast when refactoring this code block.

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 24, 2017
@koppor
Copy link
Member

koppor commented Mar 24, 2017

When the entry editor is opened, the first click on the main table causes no reaction or reshuffles the entry table. Is this caused by this fix or is this an old issue?

Ctrl+A works if I manage to focus the entry table.

@chriba
Copy link
Contributor Author

chriba commented Mar 24, 2017

woops, missed another one

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please extract both changes to new methods in MainTable and call these. Otherwise the changes look good and can be merged (-> ready-for-review tag removed).

@tobiasdiez tobiasdiez removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 29, 2017
@tobiasdiez tobiasdiez merged commit 9d60b21 into JabRef:master Apr 16, 2017
Siedlerchr added a commit that referenced this pull request Apr 19, 2017
* upstream/master:
  Reorder CHANGELOG for 4.0-beta release
  Add test that 3.8.2 should not be updated to 4.0-beta
  Fix test according to new behavior
  Sauliusg fix 2700 null pointer exception on get fulltext (#2751)
  Fix selecting all entries with shortcut (#2683)
  Incoporate feedback. Make it work for one comma (and not for two)
  Revert "allow search for words without diacritics in contain-based mode". I did not know that the push is considered in my push request
  allow search for words without diacritics in contain-based mode
  Update CHANGELOG.md
  corrected issue #2652
@chriba chriba deleted the fix2615 branch April 24, 2017 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants