Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finally write the new group properties to the bib file: icon with color, description, expanded status and automatic groups #2634

Merged
merged 7 commits into from
Mar 16, 2017

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Mar 12, 2017

Serialize and parse:

  • Icon (with customizable color) that is shown in the groups panel (implements a feature request in the forum).
  • Description text that is shown on mouse hover (implements old feature requests 489 and 818)
  • "automatic groups" that automatically create subgroups based on a certain criteria (e.g. a subgroup for every author or keyword). Implements 91, 398 and #1173.
  • Expansion status #1428

While implementing these changes, I had to introduce a new "StaticGroup" label in the bib file that replaces the old "ExplicitGroup". The problem was that the old group with legacy bib references

ExplicitGroup:StaticGroup\;0\;1137631\;1233448\;1314293\;;

otherwise couldn't be distinguished from a new explicit group with icon and color:

StaticGroup:StaticGroup\;0\;expansion\;icon\;color\;description\;;

I think we really should switch to JabRef#232 at some point.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 12, 2017
@Siedlerchr
Copy link
Member

Codewise LGTM: Just one thing I don't get from your description: The old groups can be imported right? What happens when you modify one of these old (sub) groups? Does it get changed to a new group then?

Please take a look at the codacy/checkstyle failures.

@tobiasdiez
Copy link
Member Author

Yes, the old line "ExplicitGroup.." in the file will automatically replaced by "StaticGroup..." when you save the bib file. Besides the minor differences outlined above they are treated completely the same (and this change is only related to parsing/serialization; in particular there is no new "StaticGroup" class).

Fixed the imports.

@tobiasdiez tobiasdiez merged commit 8a43694 into master Mar 16, 2017
@tobiasdiez tobiasdiez deleted the groupWriteToFile branch March 16, 2017 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants