Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complete entries with fetched infos #2307

Merged
merged 7 commits into from
Dec 3, 2016

Conversation

tobiasdiez
Copy link
Member

Bibliographic information from web resources can now be used to complete existing entries. This functionality can be accessed via a new button in the entry editor.

I think also the IdBasedFetcher like DOI can implement the EntryBased interface and thus can be made accessible to this update function. It that case, FetchAndMergeWorker may be replaced by the new EntryFetchAndMergeWorker. Something for a new PR through.

image

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 21, 2016
Copy link
Member

@lenhard lenhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this locally and it works nicely! I have just two minor comments in the code that should be fixable easily.

}));
}
JButton fetcherButton = new JButton(IconTheme.JabRefIcon.REFRESH.getIcon());
fetcherButton.setToolTipText(Localization.lang("Update with bibliographic information from the web."));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho, there is no reason for adding the period in the end. JabRef is not consistent in this, some tool tips end with periods and some do not. In my point of view, punctuation is only needed if there is a block of text for the tool tip. If it is a single sentence, no punctuation looks better.

So please remove that one :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a tooltip, the final dot should really be removed.


@Override
public void action() throws Throwable {
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this additional level of indentation?

@onewiki
Copy link

onewiki commented Nov 23, 2016

Sorry I don't know if this is the right place to ask my question, that is, whether it is possible to fetch the abstract when clicking "Get Bibtex data from DOI" (along with other data Author/Journal, etc.). Thanks!

@matthiasgeiger
Copy link
Member

matthiasgeiger commented Nov 23, 2016

@onewiki This is not possible, as the information for DOIs are resolved using crossref.org. And crossref.org does not provide abstracts, see this example: http://search.crossref.org/?q=10.2331%2Fsuisan.32.804

@onewiki
Copy link

onewiki commented Nov 23, 2016

@matthiasgeiger Thanks for explaining.

@onewiki
Copy link

onewiki commented Nov 23, 2016

@matthiasgeiger Sorry to bother you with another question (since you are knowledgeable on DOI etc.): do all articles (in social science) have DOIs, or only the ones published after year 2000?

@Siedlerchr
Copy link
Member

@matthiasgeiger This is not really right: CrossRef does provide a way to get the abstract, however, this is only possible using the XML version, see the comment:
CrossRef/rest-api-doc#98 (comment)

I recently checked that, because of a feature request in the forum:
http://discourse.jabref.org/t/export-abstract-from-text/324/2

@onewiki It depends which article a DOI has. I recently had one article from 1987 in the area of computer science which had a DOI assigned. As Publishers have to pay a fee for using a DOI, it might be that not all are willing to pay it, especially OpenAcces models.

@matthiasgeiger
Copy link
Member

Generally not all academic works have DOIs, e.g., Technical Reports published at my university only have a ISSN for the series and a "URN" as an identifier. Also workshop and conference publications exist without DOIs. Most journal articles however have DOIs - but there are also journals not using DOIs.

In my main database there are some articles published prior 2000 which have a DOI, e.g.: http://doi.org/10.1145/69605.2085 - but most older articles don't have DOIs.

@onewiki
Copy link

onewiki commented Nov 23, 2016

@Siedlerchr
Thanks, but I am a novice; could you please explain a little more what this means? "If you have a DOI use the API but append ".xml" to the end." How to do that?

@Siedlerchr
Copy link
Member

@onewiki The hint with the xml was for @matthiasgeiger. It's an implementation detail for calling the API service from JabRef, you can't do anything with.

@onewiki
Copy link

onewiki commented Nov 23, 2016

@Siedlerchr Are you saying I have to wait for the Jabref team to incorporate this feature into the program (so that it will be available in a future version)?

@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 2, 2016
@lenhard
Copy link
Member

lenhard commented Dec 2, 2016

@tobiasdiez Please fix the few very minor things mentioned above, merge the language files and then this is ready to go into master!

@tobiasdiez tobiasdiez merged commit 4efdffb into JabRef:master Dec 3, 2016
@tobiasdiez tobiasdiez deleted the entryBasedFetcher branch December 3, 2016 00:16
Siedlerchr added a commit that referenced this pull request Dec 3, 2016
* upstream/master:
  Add initial .editorconfig (#2332)
  Add complete entries with fetched infos (#2307)
  Google Scholar is also blocked on SnapCI
  Quick fix to fix failing travis
  Add Objects.requireNonNull to track down test issue on travis
  Remove obsolete xcf file
  Update to latest travis environment - see https://docs.travis-ci.com/user/build-environment-updates/2016-12-01/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants