Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "No suitable driver found" #2295

Merged
merged 1 commit into from
Nov 20, 2016
Merged

Fix "No suitable driver found" #2295

merged 1 commit into from
Nov 20, 2016

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 19, 2016

I got the error message "No suitable driver found for jdbc:pgsql://fizzy-cherry.db.elephantsql.com:5432/zdndklfq" when using the session restore of shared databases of JabRef. Google pointed me to http://stackoverflow.com/a/22384826/873282, which states that all drivers should be loaded before they are used.

This PR ensures that all available DBMS drivers are loaded before any connection attempt is made.

This does not fix #2294, which means that one has to enable autosave to be able to automatically reconnect.

@koppor koppor added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers component: shared-database labels Nov 19, 2016
@koppor koppor force-pushed the hotfixEnableReconnect branch from 2f3915f to a33d2f9 Compare November 19, 2016 23:15
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@lenhard lenhard merged commit 2f01b06 into master Nov 20, 2016
@tobiasdiez tobiasdiez deleted the hotfixEnableReconnect branch November 20, 2016 13:15
Siedlerchr added a commit that referenced this pull request Nov 27, 2016
* upstream/master: (36 commits)
  Rework DBLPFetcher to new structure (#2314)
  Consider dev tag in version comparison (#2312)
  Update diffutils from 1.3.0 to 2.1.1
  Replace usages of Throwable with Exception (#2310)
  Add missing srcDir statement
  improve documentation of save order limitation - see #2305
  Adapt CSL tests to CRLF and LF (#2306)
  Use SPDX license identifiers
  Add key format of #2275 as requirement to CONTRIBUTING.md
  Add fallback exception handler (#2287)
  Update citeproc dependency to 1.0.1 (#2303)
  Remove duplicate code getResolvedFieldOrAlias (#2296)
  Update testCompile dependencies (mockito-core, wiremock)
  Change execution order (#2302)
  Use https for files.jabref.org
  Use compileJava instead of getdeps to decrease build time even more
  Update install4j from 6.1.1 to 6.1.3
  Fix local metadata synchronization
  Fix NullPointerException in ConnectToSharedDatabaseDialog (#2297)
  The error message "No suitable driver found" will not appear when JabRef connects on startup. (#2295)
  ...

# Conflicts:
#	src/main/java/net/sf/jabref/logic/util/io/FileUtil.java
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: shared-database status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When autosave is not activated, JabRef does reconnect to shared database upon startup
3 participants