Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added links to internet resources #1821

Merged
merged 6 commits into from
Aug 26, 2016

Conversation

oscargus
Copy link
Contributor

Added links to home page, blog, and Facebook.
capture20

Not obvious where to put it in the menu nor if the "JabRef on the internet" is a good name (probably not, but cannot really find anything better).

I didn't bother adding the strings so far as I expect at least a few of them to change. :-)

  • Change in CHANGELOG.md described
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@matthiasgeiger
Copy link
Member

How about adding those links to the "About JabRef" dialog?

We already have to much menu entries, imho. 😉

@mlep
Copy link
Contributor

mlep commented Aug 23, 2016

I would say the same as @matthiasgeiger about:

  • "Online Help Forum" (since this is a secondary mean of finding help, as mentioned in http://help.jabref.org/en/ )
  • "Fork me on GitHub" (if you are a decent programmer, you do not need this item to start contributing code)

@oscargus
Copy link
Contributor Author

oscargus commented Aug 23, 2016

I was also thinking about it (main reason to use a sub menu). What about moving at least the GitHub link to the same sub menu? The forum link may be worth to keep to get the momentum up there.

Regarding adding them to the About dialog, I think that is much less used than the Help menu so if we want people to see it, it may be good to have them in the Help menu.

@oscargus
Copy link
Contributor Author

Or rename it "JabRef resources" and/or add the forum link there as well.

@oscargus
Copy link
Contributor Author

Considering the translation effort in #1824 it may not be worth trying to get this into 3.6 (avoid adding more new strings at the moment), so maybe better to wait and discuss it a bit further.

@matthiasgeiger
Copy link
Member

I still think that the other links are more important/relevant and could remain in the menu:
It is the "Help" menu - so linking to the online forum to get help is reasonable.
Showing possibilities to contribute/donate is also clearly important for us.

The web page, the blog, facebook are all rather unimportant links for the user - and for us. But if we decide to add a "JabRef resources" sub menu I would at least add the github and donate link there (icons are already shown in the toolbar) and place the submenu between "Check for updates" and "About JabRef".

And if we should reach some concensus it should be also possible to include this in 3.6 as @mlep, you and me could provide translations for the three language with the best translation status ;-)

@mlep
Copy link
Contributor

mlep commented Aug 23, 2016

I am fine with the proposal of @matthiasgeiger

@oscargus
Copy link
Contributor Author

OK! I'll have a go with that then. Just thought that 13 or whatever followers on Facebook didn't seem enough. :-)

@oscargus
Copy link
Contributor Author

New menu:

capture21

@oscargus oscargus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 23, 2016
@Siedlerchr
Copy link
Member

Looks cool! I would move Donate more upwards ;)
And I would rename Web page to Website. Apart from that ❤️

@oscargus
Copy link
Contributor Author

oscargus commented Aug 24, 2016

I changed to website. Regarding the ordering I had an idea to introduce a few more items and also separators:

Website
Blog
Facebook
(Separator)
Github
Developer version (-> builds.jabref.org/master)
Change log (-> Github master version)
(Separator)
Donate

In this way the donate link will get more attention, but I didn't want to add the other two without discussion. At least on non-Linux versions where at least on my CentOS machine, the separators are not rendered.

@matthiasgeiger
Copy link
Member

Okay - as we already introduced the submenu we can also add the other links ;-)

Instead of "Developer version", which sounds like "a version specific for developers" I propose to use "Development version"; GitHub instead of "Github" 😉

German translations:

Website=Webseite
Blog=Blog
Development_version=Entwicklungsversion
JabRef_resources=Mehr_zu_JabRef

The last one is rather hard to translate, imho... Perhaps another native speaker can come up with a better translation...

@oscargus
Copy link
Contributor Author

I was actually not planning on changing the "Fork me..." (although I would like to), so do not worry about "Github". ;-)

I agree with you regarding Developer/Development. Just couldn't figure out the better wording.

@oscargus
Copy link
Contributor Author

capture23

@oscargus
Copy link
Contributor Author

A bit annoying that the change log is shown with the development information as well. Is it possible to show only the most recent change log in some way?

@matthiasgeiger
Copy link
Member

matthiasgeiger commented Aug 24, 2016

I'm already trying to figure this out ;-)

@oscargus
Copy link
Contributor Author

I think "Mehr zu JabRef" makes sense as we might just as well have called it "More on JabRef".

@matthiasgeiger
Copy link
Member

I have not found a way to link the changelog of the latest release.. There is only the shortcut https://github.com/JabRef/jabref/releases/latest

So we either link to the master CHANGELOG or we have to put some more effort in the link creation logic by determining the current JabRef version and adding it to https://github.com/JabRef/jabref/blob/v**versionNumberHere**/CHANGELOG.md

@oscargus
Copy link
Contributor Author

oscargus commented Aug 24, 2016 via email

@mlep
Copy link
Contributor

mlep commented Aug 24, 2016

Maybe we need to be able to link to the sections of the master changelog.md file
Related to JabRef/www.jabref.org#24 ?

@Siedlerchr
Copy link
Member

@matthiasgeiger I would propose "Entwicklerversion" for Development Version as translation

@matthiasgeiger
Copy link
Member

No :-) See the discussion above: It is not a "version for developers" (==Entwicklerversion) but a version which is currently under development (==Entwicklungsversion) 😜

@oscargus
Copy link
Contributor Author

@mlep My plan was really just to link to the current CHANGELOG.md, so maybe the formulation is misleading (although correct as you can see all changes in all versions there).

@mlep
Copy link
Contributor

mlep commented Aug 24, 2016

@oscargus My misunderstanding, sorry.

@oscargus
Copy link
Contributor Author

@mlep No problems. I fully understand it (and was thinking of this possible misunderstanding when I wrote it, seems like I was correct...).

@koppor
Copy link
Member

koppor commented Aug 26, 2016

One can directly link to the release in CHANGELOG.md, when one uses the GitHub repository: One could also link the concrete release. E.g., https://github.com/JabRef/jabref/blob/master/CHANGELOG.md#35---2016-07-13

However, in the URL, the release date has also encoded. Maybe we directly change the link before each release?

@matthiasgeiger
Copy link
Member

Yeah with link changes it would be no problem - but we wanted to avoid these.

Shall we add this last minute to 3.6?

@mlep
Copy link
Contributor

mlep commented Aug 26, 2016

Since it may help in attracting attention to JabRef supporting tools, and hence foster its development, I tend to answer yes.

@oscargus
Copy link
Contributor Author

I'll resolve the merge conflicts if nothing else and let us see.

I think it is fine to link to the complete CHANGELOG.md, not just for the actual release as it is quite clear what the different versions are. I tend to think that the current solution is good enough right now, but a better looking version (without the version management stuff) can be found for 3.7.

@matthiasgeiger
Copy link
Member

@mlep Can you provide us the translations for French? 😀

@stefan-kolb
Copy link
Member

stefan-kolb commented Aug 26, 2016

I'd better liked the Jabref resources under help forum. 3 links for web resources, then error console check for updates and about dialog.

@matthiasgeiger
Copy link
Member

I like the current position 😉

@oscargus
Copy link
Contributor Author

OK, I've rebased. Still in the position of the last screen shot...

@oscargus oscargus mentioned this pull request Aug 26, 2016
@@ -2424,3 +2424,9 @@ However,_a_new_database_was_created_alongside_the_pre-3.6_one.=
Click_here_to_learn_about_the_migration_of_pre-3.6_databases.=

Connecting...=
Opens_JabRef's_Facebook_page=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation: Ouvre_la_page_Facebook_de_JabRef

@matthiasgeiger
Copy link
Member

Okay. Thanks @mlep! I'll merge the PR as is and add the French translations directly at master.

@matthiasgeiger matthiasgeiger merged commit 36aad7d into JabRef:master Aug 26, 2016
@oscargus oscargus deleted the internetresources branch August 26, 2016 10:15
ayanai1 pushed a commit to ayanai1/jabref that referenced this pull request Sep 5, 2016
* Added links to internet resources

* Rearranged menu and added translation strings

* Renamed web page to website

* Some more items and translations

* Rebased

* Norwegian menu translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ui [outdated] type: enhancement status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants