Implement 1356 #1572
Merged
Implement 1356 #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -2279,6 +2279,7 @@ Changes_the_first_letter_of_all_words_to_capital_case_and_the_remaining_letters_ | |||
| Cleans_up_LaTeX_code.=Räumt_LaTeX-Code_auf. | |||
|
|
|||
| Converts_HTML_code_to_LaTeX_code.=Konvertiere_HTML-Code_in_LaTeX-Code. | |||
| Converts_HTML_code_to_Unicode.= Konvertiere_HTML-Code_in_Unicode. | |||
There was a problem hiding this comment.
Is there a space after the = sign?
There was a problem hiding this comment.
Indeed! Thanks for spotting!
|
LGTM 👍 |
|
|
||
| @Before | ||
| public void setUp() throws Exception { | ||
| Globals.prefs = JabRefPreferences.getInstance(); |
There was a problem hiding this comment.
It is best practice to init the class under test in the @Before method so that every test method gets a fresh class, i.e move the = new HtmlToUnicodeFormatter part to this method.
There was a problem hiding this comment.
You are correct. That comes from a copy paste from the other formatter tests, which all share this problem. I will fix all of them in this PR.
|
I have only a few small remarks. 👍 for merge in general |
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1356 and provides a formatter that converts HTML to Unicode (converting characters and eliminating tags)