Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added import order for javafx packages to the eclipse settings #1518

Merged
merged 1 commit into from
Jun 27, 2016

Conversation

boceckts
Copy link
Contributor

The eclipse import order settings don't cover javafx packages but the file checkstyle.xml does. Therefore using "organize import" in eclipse gave wrong import order warnings at travis CI.

@koppor
Copy link
Member

koppor commented Jun 27, 2016

LGTM, the failing checks seem to be caused by other updates.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 27, 2016
@tobiasdiez
Copy link
Member

LGTM 👍

@tobiasdiez tobiasdiez merged commit d451721 into JabRef:javafx Jun 27, 2016
@boceckts boceckts deleted the EclipseImportOrderSettings branch July 18, 2016 10:00
bruehldev pushed a commit to bruehldev/jabref that referenced this pull request Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants