Implement getExtension and getDescription for importers #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4554cf5 to
800b247
Compare
| @@ -34,7 +35,7 @@ | |||
| * journals, e.g., Physical Review Letters, don't use pages anymore) | |||
| * | |||
| * check here for details on the format | |||
| * http://www.ecst.csuchico.edu/~jacobsd/bib/formats/endnote.html | |||
| * http://www.ecst.csuchico.edu/~jacobsd/bib/formats/endnote.html (outdated) | |||
There was a problem hiding this comment.
Can you check whether there is an other source for the endnote format?
5aa80fe to
023f63c
Compare
| @@ -37,7 +38,7 @@ | |||
| * Importer for the Medline format. | |||
| * | |||
| * check here for details on the format | |||
| * --INSERT INFO HERE-- | |||
| * http://www.nlm.nih.gov/bsd/mms/medlineelements.html | |||
There was a problem hiding this comment.
that's the wrong link, you need the link for the xml elements.
023f63c to
931fb4a
Compare
3 tasks
| @@ -234,12 +231,13 @@ public String getFormatName() { | |||
|
|
|||
| @Override | |||
| public List<String> getExtensions() { | |||
| return null; | |||
| //TODO: | |||
| @@ -226,17 +221,17 @@ private void readLine(BufferedReader in) throws IOException { | |||
|
|
|||
| /** | |||
| * Read multiple lines. | |||
| * | |||
| * <p> | |||
|
Please fix the minor things. After this, mark it again for ready-for-review and we will merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement getExtension and getDescription for importers. #1444